From e4c5f6d3d9bff233a39abe7810ba76019572fd2f Mon Sep 17 00:00:00 2001 From: Dirkjan Bussink Date: Thu, 3 Sep 2020 17:15:18 +0200 Subject: [PATCH] Fix another memory leak on invalid nid value In 906cc7e7e95047981677a43743cb7c4aa2bb3aab a memory leak was fixed but a similar one is present here that needs a fix as well. Signed-off-by: Dirkjan Bussink Reviewed-by: Jakub Jelen --- src/pki.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pki.c b/src/pki.c index a379d6c7..0d86fbcd 100644 --- a/src/pki.c +++ b/src/pki.c @@ -1218,6 +1218,10 @@ int pki_import_privkey_buffer(enum ssh_keytypes_e type, nid = pki_key_ecdsa_nid_from_name(ssh_string_get_char(i)); SSH_STRING_FREE(i); if (nid == -1) { + ssh_string_burn(e); + SSH_STRING_FREE(e); + ssh_string_burn(exp); + SSH_STRING_FREE(exp); goto fail; }