From e2841908fbe5a236ab075ac0a13c26af96f5fe64 Mon Sep 17 00:00:00 2001 From: Jakub Jelen Date: Wed, 11 Dec 2019 11:28:33 +0100 Subject: [PATCH] kex: Avoid always-false comparisons as reported by csbuild /builds/jjelen/libssh-mirror/src/kex.c:360:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] <--[cc] 360 | if (len < 0) { | ^ /builds/jjelen/libssh-mirror/src/kex.c:372:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] <--[cc] 372 | if (len < 0) { | ^ Signed-off-by: Jakub Jelen Reviewed-by: Andreas Schneider --- src/kex.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/kex.c b/src/kex.c index ae0371b0..056096cb 100644 --- a/src/kex.c +++ b/src/kex.c @@ -356,8 +356,8 @@ SSH_PACKET_CALLBACK(ssh_packet_kexinit) goto error; } - len = ssh_hashbufin_add_cookie(session, session->next_crypto->client_kex.cookie); - if (len < 0) { + ok = ssh_hashbufin_add_cookie(session, session->next_crypto->client_kex.cookie); + if (ok < 0) { ssh_set_error(session, SSH_FATAL, "ssh_packet_kexinit: adding cookie failed"); goto error; } @@ -368,8 +368,8 @@ SSH_PACKET_CALLBACK(ssh_packet_kexinit) goto error; } - len = ssh_hashbufin_add_cookie(session, session->next_crypto->server_kex.cookie); - if (len < 0) { + ok = ssh_hashbufin_add_cookie(session, session->next_crypto->server_kex.cookie); + if (ok < 0) { ssh_set_error(session, SSH_FATAL, "ssh_packet_kexinit: adding cookie failed"); goto error; }