From 48b715cce0d74c6695df5f085ed79de065ec072f Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Sat, 13 Jul 2013 13:59:14 +0200 Subject: [PATCH] tests: Use fstat() after the open(). --- tests/unittests/torture_pki.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/unittests/torture_pki.c b/tests/unittests/torture_pki.c index 20bf5c60..7324177e 100644 --- a/tests/unittests/torture_pki.c +++ b/tests/unittests/torture_pki.c @@ -86,22 +86,22 @@ static char *read_file(const char *filename) { int fd; int size; int rc; - struct stat buf; + struct stat sb; assert_true(filename != NULL); assert_true(*filename != '\0'); - rc = stat(filename, &buf); - assert_int_equal(rc, 0); - - key = malloc(buf.st_size + 1); - assert_true(key != NULL); - fd = open(filename, O_RDONLY); assert_true(fd >= 0); - size = read(fd, key, buf.st_size); - assert_true(size == buf.st_size); + rc = fstat(fd, &sb); + assert_int_equal(rc, 0); + + key = malloc(sb.st_size + 1); + assert_true(key != NULL); + + size = read(fd, key, sb.st_size); + assert_true(size == sb.st_size); close(fd);