From 1254e135fdc74cef7c11fe0bd5440a9b1046c484 Mon Sep 17 00:00:00 2001 From: "Bruce A. Mah" Date: Fri, 8 Jun 2018 11:55:33 -0700 Subject: [PATCH] Warn if doing JSON output and either -d or -v are specified. Debugging and/or verbose output can get in the way of producing valid/parsable JSON. Inspired by #737. --- src/iperf_api.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/iperf_api.c b/src/iperf_api.c index 58d4479..8b65d23 100755 --- a/src/iperf_api.c +++ b/src/iperf_api.c @@ -1231,6 +1231,14 @@ iperf_parse_arguments(struct iperf_test *test, int argc, char **argv) warning("Report format (-f) flag ignored with JSON output (-J)"); } + /* Show warning if JSON output is used with verbose or debug flags */ + if (test->json_output && test->verbose) { + warning("Verbose output (-v) may interfere with JSON output (-J)"); + } + if (test->json_output && test->debug) { + warning("Debug output (-d) may interfere with JSON output (-J)"); + } + return 0; }